Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug where overridable is not updated #594

Merged
merged 5 commits into from
Nov 28, 2022
Merged

fix bug where overridable is not updated #594

merged 5 commits into from
Nov 28, 2022

Conversation

mrinalirao
Copy link
Contributor

Description

Update the PolicySetUpdateOptions with the overridable property which was earlier missing

Testing plan

Added Acceptance tests

Output from tests

TestPolicySetsUpdate_Beta\E$
=== RUN   TestPolicySetsUpdate_Beta
--- PASS: TestPolicySetsUpdate_Beta (2.35s)
=== RUN   TestPolicySetsUpdate_Beta/with_valid_attributes
    --- PASS: TestPolicySetsUpdate_Beta/with_valid_attributes (0.32s)
PASS

@mrinalirao mrinalirao requested a review from a team as a code owner November 23, 2022 23:38
@mrinalirao mrinalirao mentioned this pull request Nov 24, 2022
Merged
glennsarti
glennsarti previously approved these changes Nov 24, 2022
View reviewed changes
glennsarti
glennsarti previously approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

brandonc
brandonc previously approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I suggested a modification to your release notes because I don't think this is a bug fix given that it is beta and not really possible for most people yet. I also mentioned the new task stage additions

@mrinalirao mrinalirao dismissed stale reviews from brandonc and glennsarti via 8d41a0f November 28, 2022 21:34
@mrinalirao @brandonc
Update CHANGELOG.md
8d41a0f 
Co-authored-by: Brandon Croft <[email protected]>
@mrinalirao mrinalirao merged commit b4eca77 into main Nov 28, 2022
@mrinalirao mrinalirao deleted the mr/policy-set-bug-fix branch November 28, 2022 21:45
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonc brandonc brandonc approved these changes

@glennsarti glennsarti glennsarti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrinalirao @brandonc @glennsarti